Skip to content

Commit dfd9b6b

Browse files
Merge pull request #4431 from Pradip-Khakurel/issue-#4161-WantShowDriverDeprecationNotification-setting
fix ShowDriverDeprecationNotification config setting
2 parents 80e200e + bb78d3e commit dfd9b6b

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

cmd/minikube/cmd/config/config.go

+4
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,10 @@ var settings = []Setting{
131131
name: Bootstrapper,
132132
set: SetString, //TODO(r2d4): more validation here?
133133
},
134+
{
135+
name: config.ShowDriverDeprecationNotification,
136+
set: SetBool,
137+
},
134138
{
135139
name: config.ShowBootstrapperDeprecationNotification,
136140
set: SetBool,

pkg/minikube/cluster/cluster.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -325,21 +325,21 @@ func preCreateHost(config *cfg.MachineConfig) {
325325
console.Warning(`The kvm driver is deprecated and support for it will be removed in a future release.
326326
Please consider switching to the kvm2 driver, which is intended to replace the kvm driver.
327327
See https://github.com/kubernetes/minikube/blob/master/docs/drivers.md#kvm2-driver for more information.
328-
To disable this message, run [minikube config set WantShowDriverDeprecationNotification false]`)
328+
To disable this message, run [minikube config set ShowDriverDeprecationNotification false]`)
329329
}
330330
case "xhyve":
331331
if viper.GetBool(cfg.ShowDriverDeprecationNotification) {
332332
console.Warning(`The xhyve driver is deprecated and support for it will be removed in a future release.
333333
Please consider switching to the hyperkit driver, which is intended to replace the xhyve driver.
334334
See https://github.com/kubernetes/minikube/blob/master/docs/drivers.md#hyperkit-driver for more information.
335-
To disable this message, run [minikube config set WantShowDriverDeprecationNotification false]`)
335+
To disable this message, run [minikube config set ShowDriverDeprecationNotification false]`)
336336
}
337337
case "vmwarefusion":
338338
if viper.GetBool(cfg.ShowDriverDeprecationNotification) {
339339
console.Warning(`The vmwarefusion driver is deprecated and support for it will be removed in a future release.
340340
Please consider switching to the new vmware unified driver, which is intended to replace the vmwarefusion driver.
341341
See https://github.com/kubernetes/minikube/blob/master/docs/drivers.md#vmware-unified-driver for more information.
342-
To disable this message, run [minikube config set WantShowDriverDeprecationNotification false]`)
342+
To disable this message, run [minikube config set ShowDriverDeprecationNotification false]`)
343343
}
344344
}
345345
}

0 commit comments

Comments
 (0)