Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better dumping via private IP when bastion is not set #17261

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

justinsb
Copy link
Member

@justinsb justinsb commented Feb 9, 2025

Previously this would always fail in a confusing way,
regardless of whether we had connectivity,
because we tried to connect to an empty-string host.

Now we are more explicit about the error,
and will at least try to connect directly.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 9, 2025
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 9, 2025
@justinsb
Copy link
Member Author

justinsb commented Feb 9, 2025

The problem I'm trying to track down is this one from the bare-metal test:

2025/02/09 21:33:23 starting to dump 3 nodes fetched through the Kubernetes APIs
2025/02/09 21:33:23 Dumping node vm0
2025/02/09 21:33:23 could not dump node vm0: connecting: unable to SSH to "10.123.45.10": ssh: handshake failed: ssh: unable to authenticate, attempted methods [none publickey], no supported methods remain
2025/02/09 21:33:23 Dumping node vm1
2025/02/09 21:33:23 could not dump node vm1: connecting: unable to SSH to "10.123.45.11": ssh: handshake failed: ssh: unable to authenticate, attempted methods [none publickey], no supported methods remain
2025/02/09 21:33:23 Dumping node vm2
2025/02/09 21:33:23 could not dump node vm2: connecting: unable to SSH to "10.123.45.12": ssh: handshake failed: ssh: unable to authenticate, attempted methods [none publickey], no supported methods remain

Previously this would always fail in a confusing way,
regardless of whether we had connectivity,
because we tried to connect to an empty-string host.

Now we are more explicit about the error,
and will at least try to connect directly.
@justinsb justinsb force-pushed the ssh_metal_test_oddity branch from 13a51bb to 3ea73f4 Compare February 19, 2025 13:27
@justinsb justinsb changed the title WIP: Diagnose odd failures in metal test with dumper Better dumping via private IP when bastion is not set Feb 19, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 19, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2025
@k8s-ci-robot k8s-ci-robot merged commit fe9f2f6 into kubernetes:master Feb 20, 2025
23 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants