-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bare-metal: add some go tests to start to verify functionality #16896
Conversation
(I'm testing whether status.addresses and spec.podCIDRs are set ... amusingly they seem to be here, but they aren't - currently - set in my real environment - I guess that's a win?) |
5972bb8
to
cd34a15
Compare
cd34a15
to
531d11b
Compare
531d11b
to
ee78cce
Compare
0380bb6
to
a60890b
Compare
From the Github actions log:
That's what I was hoping for - we're now able to do some simple "smoketests" on the cluster. |
/retest |
@justinsb: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! 🙂
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.