Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bare-metal: add some go tests to start to verify functionality #16896

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

justinsb
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 12, 2024
@justinsb
Copy link
Member Author

(I'm testing whether status.addresses and spec.podCIDRs are set ... amusingly they seem to be here, but they aren't - currently - set in my real environment - I guess that's a win?)

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 20, 2025
@justinsb justinsb force-pushed the metal_node_addresses branch from 5972bb8 to cd34a15 Compare January 20, 2025 13:31
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 20, 2025
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 1, 2025
@justinsb justinsb force-pushed the metal_node_addresses branch from cd34a15 to 531d11b Compare February 9, 2025 15:02
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 9, 2025
@justinsb justinsb force-pushed the metal_node_addresses branch from 531d11b to ee78cce Compare February 9, 2025 18:20
@justinsb justinsb force-pushed the metal_node_addresses branch from 0380bb6 to a60890b Compare February 9, 2025 21:16
@justinsb
Copy link
Member Author

justinsb commented Feb 9, 2025

From the Github actions log:

=== RUN   TestNodeAddresses
    e2e_test.go:44: node vm0 has addresses: [{InternalIP 10.123.45.10} {Hostname vm0}]
    e2e_test.go:44: node vm1 has addresses: [{InternalIP 10.123.45.11} {Hostname vm1}]
    e2e_test.go:44: node vm2 has addresses: [{InternalIP 10.123.45.12} {Hostname vm2}]
--- PASS: TestNodeAddresses (0.01s)

That's what I was hoping for - we're now able to do some simple "smoketests" on the cluster.

@justinsb justinsb changed the title WIP: bare-metal: add some go tests to start to verify functionality bare-metal: add some go tests to start to verify functionality Feb 9, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 9, 2025
@justinsb
Copy link
Member Author

justinsb commented Feb 9, 2025

/retest

@k8s-ci-robot
Copy link
Contributor

@justinsb: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-e2e-cni-flannel 5972bb8 link true /test pull-kops-e2e-cni-flannel
pull-kops-e2e-gce-cni-calico 5972bb8 link true /test pull-kops-e2e-gce-cni-calico
pull-kops-e2e-gce-cni-kindnet 5972bb8 link true /test pull-kops-e2e-gce-cni-kindnet
pull-kops-e2e-k8s-aws-amazonvpc-u2404 cd34a15 link true /test pull-kops-e2e-k8s-aws-amazonvpc-u2404
pull-kops-kubernetes-e2e-ubuntu-gce-build a60890b link false /test pull-kops-kubernetes-e2e-ubuntu-gce-build

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Member

@hakman hakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🙂

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 10, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2025
@k8s-ci-robot k8s-ci-robot merged commit 4a42841 into kubernetes:master Feb 10, 2025
23 of 24 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants