Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

releng: Image promotion for v1.18.16 / v1.18.17-rc.0 / v1.19.8 / v1.19.9-rc.0 / v1.20.3 / v1.20.4-rc.0 #1670

Merged
merged 1 commit into from
Feb 17, 2021
Merged

releng: Image promotion for v1.18.16 / v1.18.17-rc.0 / v1.19.8 / v1.19.9-rc.0 / v1.20.3 / v1.20.4-rc.0 #1670

merged 1 commit into from
Feb 17, 2021

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Feb 17, 2021

Image promotion for Kubernetes v1.18.16 / v1.18.17-rc.0 / v1.19.8 / v1.19.9-rc.0 / v1.20.3 / v1.20.4-rc.0
This is an automated PR generated from krel The Kubernetes Release Toolbox

/hold
cc: @kubernetes/release-engineering

@cpanato
releng: Image promotion for v1.18.16 / v1.18.17-rc.0 / v1.19.8 / v1.1…
63c134d 
…9.9-rc.0 / v1.20.3 / v1.20.4-rc.0

Signed-off-by: cpanato <[email protected]>
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 17, 2021
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 17, 2021
xmudrii
xmudrii approved these changes Feb 17, 2021
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 17, 2021
@ameukam
Copy link
Member

ameukam commented Feb 17, 2021

/lgtm

saschagrunert
saschagrunert approved these changes Feb 17, 2021
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, saschagrunert, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@puerco
Copy link
Member

puerco commented Feb 17, 2021

/lgtm

@puerco
Copy link
Member

puerco commented Feb 17, 2021

Thanks @cpanato !
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 17, 2021
@k8s-ci-robot k8s-ci-robot merged commit 4e19ff8 into kubernetes:main Feb 17, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 17, 2021
@cpanato cpanato deleted the v1.18.16-image-promotion branch February 18, 2021 08:28
This was referenced Feb 18, 2021
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@xmudrii xmudrii xmudrii approved these changes

@alejandrox1 alejandrox1 Awaiting requested review from alejandrox1

@puerco puerco Awaiting requested review from puerco

Assignees

@saschagrunert saschagrunert

@ameukam ameukam

@puerco puerco

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
6 participants
@cpanato @ameukam @k8s-ci-robot @puerco @saschagrunert @xmudrii