Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the sed command to work on macOS #993

Merged
merged 1 commit into from
Jul 18, 2017
Merged

Fix the sed command to work on macOS #993

merged 1 commit into from
Jul 18, 2017

Conversation

johnbelamaric
Copy link
Member

The sed -i doesn't work on macOS, it requires a zero-length extension. So use sed -i '' on macOS.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 18, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 44.215% when pulling ba7e8f1 on johnbelamaric:fix-sed into 6f07f3b on kubernetes:master.

@aledbf aledbf self-assigned this Jul 18, 2017
@aledbf
Copy link
Member

aledbf commented Jul 18, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 18, 2017
@aledbf
Copy link
Member

aledbf commented Jul 18, 2017

@johnbelamaric thanks!

@aledbf aledbf merged commit 652b39f into kubernetes:master Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aledbf aledbf

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@johnbelamaric @k8s-reviewable @coveralls @aledbf @k8s-ci-robot