ingress losing real source IP when tls enabled

[grantwnorman]

Followed the example at https://github.com/kubernetes/ingress/tree/master/examples/aws/nginx and created an ingress setup. I put an echoheaders service behind the ingress and get the correct real ip from the headers when hitting it with curl:

% curl http://www.mydomain.com
CLIENT VALUES:
client_address=100.96.21.40
command=GET
real path=/
query=nil
request_version=1.1
request_uri=http://www.mydomain.com:8080/

SERVER VALUES:
server_version=nginx: 1.10.0 - lua: 10001

HEADERS RECEIVED:
accept=*/*
connection=close
host=www.mydomain.com
user-agent=curl/7.51.0
x-forwarded-for=24.249.x.x
x-forwarded-host=www.mydomain.com
x-forwarded-port=80
x-forwarded-proto=http
x-original-uri=/
x-real-ip=24.249.x.x
x-scheme=http
BODY:
-no body in request-

But as soon as I add in tls, it no longer gives me the correct external IP, but resorts to a 127.0.0.1:

%curl https://www.mydomain.com
CLIENT VALUES:
client_address=100.96.21.40
command=GET
real path=/
query=nil
request_version=1.1
request_uri=http://www.mydomain.com:8080/

SERVER VALUES:
server_version=nginx: 1.10.0 - lua: 10001

HEADERS RECEIVED:
accept=*/*
connection=close
host=www.mydomain.com
user-agent=curl/7.51.0
x-forwarded-for=127.0.0.1
x-forwarded-host=www.mydomain.com
x-forwarded-port=443
x-forwarded-proto=https
x-original-uri=/
x-real-ip=127.0.0.1
x-scheme=https
BODY:
-no body in request-

Here is my ingress configuration with tls added in and it works in the browser

kind: Ingress
metadata:
  annotations:
    kubernetes.io/ingress.class: nginx
  name: echo
  namespace: my-namespace
spec:
  rules:
  - host: www.mydomain.com
    http:
      paths:
      - backend:
          serviceName: echoheaders
          servicePort: 80
        path: /
  - host: mydomain.com
    http:
      paths:
      - backend:
          serviceName: echoheaders
          servicePort: 80
        path: /
  tls:
  - hosts:
    - www.mydomain.com
    - mydomain.com
    secretName: mydomain-rapidssl-2018
status:
  loadBalancer:
    ingress:
    - ip: 34.209.3.6
    - ip: 35.165.179.67

Is this something I am doing wrong here or is this a known issue?

[aledbf]

@grantwnorman this a known issue being fixed

[grantwnorman]

awesome, are there any issue numbers you could reference so I can follow the progress on this?

[grantwnorman]

nm, I found it I think. Thanks!

[aledbf]

Closing. Fix already in master