Enhance Certificate Logging and Clearup Mutual Auth Docs #1426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
k8s-ci-robot
added
the
size/M
aledbf
reviewed
Sep 27, 2017
| @@ -671,29 +671,6 @@ func (ic *GenericController) getBackendServers(ingresses []*extensions.Ingress) | |||
| return aUpstreams, aServers | |||
| } | |||
|
|
|||
| // GetAuthCertificate ... | |||
| func (ic GenericController) GetAuthCertificate(secretName string) (*resolver.AuthSSLCert, error) { | |||
There was a problem hiding this comment.
You cannot remove this function. It's used in the auth cert annotation parser
There was a problem hiding this comment.
I see and it is in ingress-controller because it deals with secret objects part of the ingress controller.
Adds better logging to errors caused when getting a Certificate. Adds notes and updates documentation for Mutual Authentication.
diazjf
commented
Sep 27, 2017
| @@ -509,9 +509,13 @@ func (ic *GenericController) getBackendServers(ingresses []*extensions.Ingress) | |||
| ca := ic.annotations.CertificateAuth(ing) | |||
| if ca != nil { | |||
| server.CertificateAuth = *ca | |||
There was a problem hiding this comment.
When building the annotation we just check if the secret exists in GetAuthCertificate, then cast it into an *ingress.SSLCert and then build the AuthSSLCert, but there are paths if the secret is created with tls.crt and tls.key but no ca.crt that CAFileName will be "".
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@diazjf thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds better logging to errors cause when getting a Certificate. Adds notes and updates documentation for Mutual Authentication, as well as removes unused function for Mutual Authentication.