Skip to content

proposal: application health check #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mqliang opened this issue Jan 18, 2017 · 3 comments
Closed

proposal: application health check #140

mqliang opened this issue Jan 18, 2017 · 3 comments

Comments

@mqliang
Copy link

mqliang commented Jan 18, 2017

It's useful to provide backend health check functionality, it could be implemented by integrating ngx_http_healthcheck_module

@euank
Copy link
Contributor

euank commented Jan 18, 2017

@mqliang that repo itself states that it's deprecated in favour of https://github.com/yaoweibin/nginx_upstream_check_module, so such an implementation should probably use different nginx features.

By default though, the controller will remove backends that have failed the kubernetes defined healthchecks, so you can already define kubernetes healthchecks for your pod and have some functionality there.

See this doc for what exists now: https://github.com/kubernetes/ingress/blob/5cdb8fe4fb3d0d4bc4430a09726810b5daddb949/controllers/nginx/configuration.md#custom-nginx-upstream-checks

What feature do you specifically want and what usecase which isn't already covered by k8s healthchecks?

@chrismoos
Copy link
Contributor

I did this PR when ingress was getting moved over here:

kubernetes-retired/contrib#2072

I'll try to get it rebased over here.

@aledbf
Copy link
Member

aledbf commented Jun 16, 2017

Closing. Please use the readiness and liveness probes provided by Kubernetes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants