This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
Allow customisation of the nginx proxy_buffer_size directive via ConfigMap #1743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
probably won't get time to look at this before monday because of the 1.4 release, hopefully by then though. Manuel might have time to review. |
|
LGTM |
|
good enough :) |
|
Automatic merge from submit-queue |
aledbf
pushed a commit
to aledbf/contrib
that referenced
this pull request
Nov 10, 2016
…-controller-proxy-buffer-size-2 Automatic merge from submit-queue Allow customisation of the nginx proxy_buffer_size directive via ConfigMap I'm opening a new PR with the same changes as kubernetes-retired#1693 because I pushed the latter with an email address that can't be used to sign the CLA. Description from the previous PR: When using nginx as a proxy we can run into the following error: ``` upstream sent too big header while reading response header from upstream ``` In order to fix this, we need to be able to configure the proxy_buffer_size nginx directive to increase its value. This PR updates the nginx-ingress-controller to allow that.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm opening a new PR with the same changes as #1693 because I pushed the latter with an email address that can't be used to sign the CLA. Description from the previous PR:
When using nginx as a proxy we can run into the following error:
In order to fix this, we need to be able to configure the proxy_buffer_size nginx directive to increase its value. This PR updates the nginx-ingress-controller to allow that.
This change is