Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong go env in Makefile? #158

Closed
camper42 opened this issue Dec 2, 2020 · 1 comment · Fixed by #159
Closed

wrong go env in Makefile? #158

camper42 opened this issue Dec 2, 2020 · 1 comment · Fixed by #159

Comments

@camper42
Copy link

camper42 commented Dec 2, 2020

cloud-provider-aws/Makefile

Line 48 in 1be8de7

CGO111MODULE=on GO_ENABLED=0 GOOS=$(GOOS) go build \

should be GO111MODULE & CGO_ENABLED?
@ayberk
Copy link
Contributor

ayberk commented Dec 3, 2020

Good catch! I'll send a PR.

@ayberk ayberk mentioned this issue Dec 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix build command ayberk/cloud-provider-aws
2 participants
@ayberk @camper42