-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: upstream Azure managed instance cache refactor for 1.28 #7119
refactor: upstream Azure managed instance cache refactor for 1.28 #7119
Conversation
Hi @comtalyst. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
a4f6c43
to
7ffac22
Compare
Testing approval |
/approve |
@Bryce-Soghigian, @comtalyst Looks like OWNERS is branch-specific, so need to propagate the change to all active branches |
7ffac22
to
0343190
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bryce-Soghigian, comtalyst The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4fe5385
into
kubernetes:cluster-autoscaler-release-1.28
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
"Refactor" as a part of fork-upstream (managed-selfhosted) realignment. Should not have any breaking changes.
This codebases realignment will simplify the logistics between the two, cutting a significant portion of maintenance cost.
This PR specifically focus on instance caching.
There will be a separate effort focusing on improve code quality, rather than realigning codebase.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Most changes are merely refactor. Also include small fixes to refresh instance cache in more cases that should be required. Also include support for currently managed-exclusive flags (e.g.,
EnableDetailedCSEMessage
).There are similar PRs out on master and other version release branches as well. Should be near identical.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: