Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

empty ProviderID block RunOnce #6546

Closed
daimaxiaxie opened this issue Feb 20, 2024 · 1 comment · Fixed by #6507
Closed

empty ProviderID block RunOnce #6546

daimaxiaxie opened this issue Feb 20, 2024 · 1 comment · Fixed by #6507
Labels
area/cluster-autoscaler kind/bug Categorizes issue or PR as related to a bug.

Comments

@daimaxiaxie
Copy link
Contributor

Which component are you using?:

Cluster Autoscaler

What version of the component are you using?:

Component version: 1.28.0

What k8s version are you using (kubectl version)?:

kubectl version Output
$ kubectl version
Client Version: version.Info{Major:"1", Minor:"19", GitVersion:"v1.19.16", GitCommit:"e37e4ab4cc8dcda84f1344dda47a97bb1927d074", GitTreeState:"clean", BuildDate:"2021-10-27T16:25:59Z", GoVersion:"go1.15.15", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"19+", GitVersion:"v1.19.3-5", GitCommit:"dcc97265743078854c5328e30727147bdc5d1c37", GitTreeState:"clean", BuildDate:"2020-12-04T03:52:29Z", GoVersion:"go1.15.5", Compiler:"gc", Platform:"linux/amd64"}

What environment is this in?:

ali, ali cloud provider

What did you expect to happen?:

When there is an empty ProviderID node in the cluster, the Cluster Autoscaler is not affected.

What happened instead?:

Empty ProviderID node blocks RunOnce, it can't scale up and down.

Log:

I0122 18:14:46.304776       1 static_autoscaler.go:287] Starting main loop
I0122 18:14:46.305345       1 mixed_nodeinfos_processor.go:81] GetNodeInfosForGroups: nodes **
I0122 18:14:46.305358       1 mixed_nodeinfos_processor.go:216] Scheduled pods ***
I0122 18:14:46.305389       1 mixed_nodeinfos_processor.go:122] GetNodeInfosForGroups: starting to process ready node
E0122 18:14:46.305610       1 alicloud_cloud_provider.go:135] failed to get instance Id from provider Id:,because of AliCloud: unexpected ProviderID format, providerID=
E0122 18:14:46.305620       1 static_autoscaler.go:359] Failed to get node infos for groups: AliCloud: unexpected ProviderID format, providerID=
I0122 18:15:01.305715       1 static_autoscaler.go:287] Starting main loop

How to reproduce it (as minimally and precisely as possible):

In the ali cloud environment, add an empty ProviderID node to the cluster.

Anything else we need to know?:

NodeGroupForNode in ali cloud provider will return err, make MixedTemplateNodeInfoProvider.Process return an error early, main loop ends.

@daimaxiaxie daimaxiaxie added the kind/bug Categorizes issue or PR as related to a bug. label Feb 20, 2024
@Shubham82
Copy link
Contributor

/area cluster-autoscaler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cluster-autoscaler kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants