From ee49e32269f5f28a20faafde58b78b0ce643cb67 Mon Sep 17 00:00:00 2001 From: vadasambar Date: Fri, 7 Jul 2023 11:48:59 +0530 Subject: [PATCH] test(cloudprovider/externalgrpc): add assert for `MaxNodeProvisionTime` - add extra assert for err test case Signed-off-by: vadasambar --- .../externalgrpc/externalgrpc_node_group_test.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/cluster-autoscaler/cloudprovider/externalgrpc/externalgrpc_node_group_test.go b/cluster-autoscaler/cloudprovider/externalgrpc/externalgrpc_node_group_test.go index 4ad438f4fd08..870fcb646b1c 100644 --- a/cluster-autoscaler/cloudprovider/externalgrpc/externalgrpc_node_group_test.go +++ b/cluster-autoscaler/cloudprovider/externalgrpc/externalgrpc_node_group_test.go @@ -250,6 +250,8 @@ func TestCloudProvider_GetOptions(t *testing.T) { assert.Equal(t, 0.7, opts.ScaleDownGpuUtilizationThreshold) assert.Equal(t, time.Minute, opts.ScaleDownUnneededTime) assert.Equal(t, time.Hour, opts.ScaleDownUnreadyTime) + assert.Equal(t, time.Hour, opts.ScaleDownUnreadyTime) + assert.Equal(t, time.Minute, opts.MaxNodeProvisionTime) // test grpc error m.On( @@ -266,8 +268,9 @@ func TestCloudProvider_GetOptions(t *testing.T) { client: client, } - _, err = ng2.GetOptions(defaultsOpts) + opts, err = ng2.GetOptions(defaultsOpts) assert.Error(t, err) + assert.Nil(t, opts) // test no opts m.On(