Decrease node group size only if the node pass resource check for sca…

…le down candidate
kubernetes · Feb 16, 2023 · 2f6867d · 2f6867d
1 parent 60a264b
commit 2f6867d
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 1 deletion.
diff --git a/cluster-autoscaler/core/scaledown/legacy/__debug_bin b/cluster-autoscaler/core/scaledown/legacy/__debug_bin
diff --git a/cluster-autoscaler/core/scaledown/unneeded/nodes.go b/cluster-autoscaler/core/scaledown/unneeded/nodes.go
@@ -185,7 +185,6 @@ func (n *Nodes) unremovableReason(context *context.AutoscalingContext, v *node,
 	if reason := verifyMinSize(node.Name, nodeGroup, nodeGroupSize, as); reason != simulator.NoReason {
 		return reason
 	}
-	nodeGroupSize[nodeGroup.Id()]--
 
 	resourceDelta, err := n.limitsFinder.DeltaForNode(context, node, nodeGroup, resourcesWithLimits)
 	if err != nil {
@@ -209,6 +208,7 @@ func (n *Nodes) unremovableReason(context *context.AutoscalingContext, v *node,
 		return simulator.MinimalResourceLimitExceeded
 	}
 
+	nodeGroupSize[nodeGroup.Id()]--
 	return simulator.NoReason
 }