You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I see that the wait.Poll method is still widely used in unit tests and integration tests. This method has been deprecated in favor of PollUntilContextTimeout.
We should replace this method
// Deprecated: This method does not return errors from context, use PollUntilContextTimeout.
// Note that the new method will no longer return ErrWaitTimeout and instead return errors
// defined by the context package. Will be removed in a future release.
func Poll(interval, timeout time.Duration, condition ConditionFunc) error {
return PollWithContext(context.Background(), interval, timeout, condition.WithContext())
}
What did you expect to happen?
replace Poll method to PollUntilContextTimeout
How can we reproduce it (as minimally and precisely as possible)?
No response
Anything else we need to know?
No response
Kubernetes version
None
$ kubectl version
# paste output here
Scheduler Plugins version
None
The text was updated successfully, but these errors were encountered:
Area
Other components
No response
What happened?
I see that the
wait.Poll
method is still widely used in unit tests and integration tests. This method has been deprecated in favor ofPollUntilContextTimeout
.We should replace this method
What did you expect to happen?
replace
Poll
method toPollUntilContextTimeout
How can we reproduce it (as minimally and precisely as possible)?
No response
Anything else we need to know?
No response
Kubernetes version
None
Scheduler Plugins version
None
The text was updated successfully, but these errors were encountered: