Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replacements entries get source and targets with null value appended #4270

Closed
616b2f opened this issue Nov 8, 2021 · 2 comments · Fixed by #4271
Closed

replacements entries get source and targets with null value appended #4270

616b2f opened this issue Nov 8, 2021 · 2 comments · Fixed by #4271
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@616b2f
Copy link

616b2f commented Nov 8, 2021

replacements entries get source and targets appended

when we edit an image to an kustomization.yaml file that has replacements in it, it adds source and targets properties with null values to them:

Example:

kustomization.yaml

apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

replacements:
  - path: replacement.yaml
$ kustomize edit set image mycr.io/myimage:v1.0

Expected output

apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

replacements:
- path: replacement.yaml
images:
- name: mycr.io/image
  newTag: v1.0

Actual output

apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

replacements:
- path: replacement.yaml
  source: null
  targets: null
images:
- name: mycr.io/image
  newTag: v1.0

Kustomize version

4.4.0

Platform

Linux

@616b2f 616b2f added the kind/bug Categorizes issue or PR as related to a bug. label Nov 8, 2021
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Nov 8, 2021
@natasha41575
Copy link
Contributor

/assign
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 8, 2021
@natasha41575
Copy link
Contributor

This has been fixed at will be available in the next release (coming out this week). Thanks for filing the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants