Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e tests should fail if default skeleton began to be incompatible with the k8s versions used #2504

Closed
camilamacedo86 opened this issue Feb 1, 2022 · 2 comments
Closed

e2e tests should fail if default skeleton began to be incompatible with the k8s versions used #2504

camilamacedo86 opened this issue Feb 1, 2022 · 2 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@camilamacedo86
Copy link
Member

What do you want to happen?

The changes in the PR #2498 make the default skeleton began to be incompatible with the k8s versions used to do the tests but the tests do not fail as should be.

The goal of this task is to improve the e2e test to ensure that we will not introduce breaking changes like this one. See: #2498 (comment)

Extra Labels

No response
@camilamacedo86 camilamacedo86 added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 1, 2022
@camilamacedo86 camilamacedo86 mentioned this issue Feb 1, 2022
Closed
@camilamacedo86 camilamacedo86 added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Feb 7, 2022
@NikhilSharmaWe
Copy link
Member

@camilamacedo86 Could you please elaborate. The issue you mentioned above is related to the kustomize version, but the goal of this issue is related to making tests fail based on kubernetes version.

Could you please explain what are we trying to achieve here.

@camilamacedo86
Copy link
Member Author

Hi @NikhilSharmaWe,

We open this one because we thought that our e2e test should get that.
However, by analysing it deeper we could realize that does not happened because:
a) Our default scaffolds still compatible with V4
b) For now at least, and to help authors customize maintainers are keep what is deprecated so the things will still working

In this way, we have nothing to do in our e2e test and I am closing this one as sorted out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@camilamacedo86 @NikhilSharmaWe