Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI is broken because prow was changed and is looking for the wrong file #1191

Closed
camilamacedo86 opened this issue Nov 12, 2019 · 7 comments
Closed
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@camilamacedo86
Copy link
Member

camilamacedo86 commented Nov 12, 2019

/kind bug

Following the Prow issue:

could not start the process: fork/exec ./test_e2e.sh: no such file or directory

Note that the file which has been used by so far is: https://github.com/kubernetes-sigs/kubebuilder/blob/master/test_ci.sh and it was changed

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 12, 2019
@camilamacedo86
Copy link
Member Author

c/c @DirectXMan12 @mengqiy @droot

@camilamacedo86
Copy link
Member Author

/assign @camilamacedo86

@Adirio
Copy link
Contributor

Adirio commented Nov 12, 2019

I was going to open a new issue so will just comment here instead:

Description

PR are failing the pull-kubebuilder-e2e test with the following message:
could not start the process: fork/exec ./test_e2e.sh: no such file or directory

Notes:

Some notes that may be relevant aside from what @camilamacedo86 already mentioned:

  • The repository has two files with similar names (test_e2e_v1.sh and test_e2e_v2.sh) but no file with that name.
  • 🏃 more robust golden test #1107 renamed test_e2e.sh to test_e2e_v1.sh, but it may have leaked somewhere an old reference to that file.

Example PR:

@camilamacedo86
Copy link
Member Author

Hi @DirectXMan12 @mengqiy @droot

Note that the error could not start the process: fork/exec ./test_e2e.sh: no such file or directory we can solve but now it also is calling 2 jobs one for the tests_ci and other which shows to be for e2e. However, to run the e2e we need to create a specific setup since it cannot be as it is done for the Travis. The #1151 may make things more clear.

@mengqiy
Copy link
Member

mengqiy commented Nov 12, 2019

pull-kubebuilder-e2e is an optional check and doesn't block PRs from merging.
@alexeldeib is working on using Prow for e2e testing.

@camilamacedo86
Copy link
Member Author

Closing this one since the default check is solved and pull-kubebuilder-e2e was clarified.

@alexeldeib
Copy link
Contributor

Sorry for the confusion, I should have held the test infra PR as well until the refactor in e2e was done. But as it is optional presubmit, it should not block PRs. It will look ugly though 🙁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

5 participants