AWS: select only one Hosted Zone to create the Route53 records

[leonardocaylent]

Previous context needed:
The issue: link
This Pull Request: link

Current behavior:
User has 3 hosted zones in AWS:
Public: mydomain.com
Private: internal.mydomain.com
Private: us-west-2.internal.mydomain.com

User creates an ingress with host: testdeploy.us-west-2.internal.mydomain.com
One A record to the AWS Load Balancer is created on each of the 3 Hosted Zones to k8s-ingress-1234abcd.us-west-2.elb.amazonaws.com with the corresponding 2 TXT records.

Desired behavior:
The external-dns controller should detect that the record is only wanted on the us-west-2.internal.mydomain.com Hosted Zone in this case.

Discussion:
This will be done modifying the current function suitableZones on the aws.go provider. With the addition of rolling back the fix for overlapping zones and a regression to check that:

1. Users that update to the new version of external-dns will plan to delete the unused Route53 Records
2. Users that start using external-dns on the new version won't be affected at all
3. Try to detect use cases where a feature flag is needed to keep the original behavior (We really don't want to do this but if there are use cases for this we'll need to think about a solution for this)

cc: @Raffo @mloiseleur

[leonardocaylent]

Additional information:
In the case of adding the record myapp.us-west-2.internal.mydomain.com and having this 3 hosted zones:
Public: mydomain.com
Private: internal.mydomain.com
Private: us-west-2.internal.mydomain.com

The record should be only created at us-west-2.internal.mydomain.com

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[leonardocaylent]

/remove-lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle rotten
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[mloiseleur]

/retitle feat(aws): select only one Hosted Zone to create the Route53 records

[mloiseleur]

/retitle AWS: select only one Hosted Zone to create the Route53 records

[mloiseleur]

@leonardocaylent Is this issue solved or did I missed something ?