Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document metrics exposed by the library #134

Closed
dgrisonnet opened this issue Dec 14, 2022 · 5 comments · Fixed by #169
Closed

Document metrics exposed by the library #134

dgrisonnet opened this issue Dec 14, 2022 · 5 comments · Fixed by #169
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@dgrisonnet
Copy link
Member

We should add a documentation that would easily be consumable by our users.

We could do something similar to Kubernetes in https://kubernetes.io/docs/reference/instrumentation/metrics/ and reuse their static analysis tool that generates the doc.

@dgrisonnet dgrisonnet added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation. labels Dec 14, 2022
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Dec 14, 2022
@dgrisonnet dgrisonnet added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Dec 14, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Dec 14, 2022
@olivierlemasle
Copy link
Member

/assign

@k8s-triage-robot
Copy link

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

  • Confirm that this issue is still relevant with /triage accepted (org members only)
  • Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. and removed triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Jan 19, 2024
@dashpole
Copy link

dashpole commented Mar 7, 2024

/triage accepted
@olivierlemasle are you still interested in taking this on?

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 7, 2024
@hjet
Copy link
Contributor

hjet commented Mar 29, 2024

@dashpole happy to grab this one, will have time to work on this in the coming days. i'll aim to follow the approach described above by @dgrisonnet (found the tool here)

@hjet
Copy link
Contributor

hjet commented Apr 4, 2024

so from what i can tell, only one metric is exposed by this library.

would it be okay to create a doc (manually) in docs/ following the same structure as this doc, or should i write a quick script that copies the tool and runs it on this repo to generate the doc?

edit: i see now that there are inherited metrics from apiserver and ../component-base/.../workqueue -- i don't think that tool performs deep analysis into imported packages so would essentially have to feed it this repo, as well as apiserver and workqueue metric defs... not the cleanest solution but likely better than nothing. let me know if this approach makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants