Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add IsZero method to reconcile.Result #1059

Merged
merged 1 commit into from
Jul 21, 2020
Merged

✨ Add IsZero method to reconcile.Result #1059

merged 1 commit into from
Jul 21, 2020

Conversation

vincepri
Copy link
Member

Signed-off-by: Vince Prignano [email protected]

/assign @alvaroaleman

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 21, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 21, 2020
@vincepri vincepri mentioned this pull request Jul 21, 2020
Closed
@vincepri vincepri force-pushed the add-iszero-result branch from 3fcd0b5 to 3c8c10e Compare July 21, 2020 02:30
@coderanger
Copy link
Contributor

Might want to use a pointer receiver to avoid a heap copy? Guessing this intended to be fast :)

@vincepri vincepri force-pushed the add-iszero-result branch from 3c8c10e to c2c91b0 Compare July 21, 2020 03:02
@vincepri
Copy link
Member Author

@coderanger Having it as a non-pointer makes it possible to use it on a nil variable as well, which was the intent behind it

alvaroaleman
alvaroaleman approved these changes Jul 21, 2020
View reviewed changes
Copy link
Member

@alvaroaleman alvaroaleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 21, 2020
@vincepri
Copy link
Member Author

/test pull-controller-runtime-test-master

1 similar comment
@vincepri
Copy link
Member Author

/test pull-controller-runtime-test-master

@vincepri vincepri force-pushed the add-iszero-result branch from c2c91b0 to bef7dd5 Compare July 21, 2020 03:25
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 21, 2020
@vincepri
Copy link
Member Author

vincepri commented Jul 21, 2020 •
edited
Loading

@coderanger I stand corrected, we do want to have it as a pointer receiver to check if it's nil, thanks for pointing it out!

@alvaroaleman Sidenote, we're still running coverage using parallel tests

alvaroaleman
alvaroaleman approved these changes Jul 21, 2020
View reviewed changes
Copy link
Member

@alvaroaleman alvaroaleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 21, 2020
@k8s-ci-robot k8s-ci-robot merged commit c5fc2a5 into kubernetes-sigs:master Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvaroaleman alvaroaleman alvaroaleman approved these changes

@mengqiy mengqiy Awaiting requested review from mengqiy

Assignees

@alvaroaleman alvaroaleman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vincepri @k8s-ci-robot @coderanger @alvaroaleman