Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Linting Tracking Issue #11834

Open
11 of 14 tasks
JoelSpeed opened this issue Feb 12, 2025 · 5 comments
Open
11 of 14 tasks

API Linting Tracking Issue #11834

JoelSpeed opened this issue Feb 12, 2025 · 5 comments
Assignees
@tsuzu @sivchari
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@JoelSpeed
Copy link
Contributor

JoelSpeed commented Feb 12, 2025 •
edited by sbueringer
Loading

As part of #11733, we have configured KAL, that kube-api-linter to run against the APIs within this repository.

There are a number of linter rules that need to be reviewed and enabled 1 by 1.

This issue is to track the implementation of enabling each of these linters

TODO

Not doing

NoPhase

Per discussion in July 2024, we are keeping phase fields for now.
See #10897 (comment) and #10897 (comment) for the context on why we are still keeping phases.
@k8s-ci-robot k8s-ci-robot added needs-priority Indicates an issue lacks a `priority/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 12, 2025
@JoelSpeed JoelSpeed mentioned this issue Feb 12, 2025
Merged
@fabriziopandini fabriziopandini added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Feb 13, 2025
@k8s-ci-robot k8s-ci-robot removed needs-priority Indicates an issue lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 13, 2025
@fabriziopandini fabriziopandini added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Feb 13, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Feb 13, 2025
@JoelSpeed JoelSpeed mentioned this issue Feb 14, 2025
Merged
@sivchari
Copy link
Member

sivchari commented Feb 17, 2025 •
edited
Loading

Hi @JoelSpeed
I'd work on this.
/assign

@JoelSpeed
Copy link
Contributor Author

By all means! Just comment here before you pick up one of the rules to enable as between us I think we can open up the PRs in parallel for discussion

This was referenced Feb 19, 2025
Merged
Merged
Merged
This was referenced Feb 27, 2025
Merged
Merged
Merged
Open
Merged
Merged
@sivchari
Copy link
Member

I opened the PR for each linter to make it enabled

@tsuzu
Copy link
Contributor

tsuzu commented Mar 4, 2025

I'm working on commentstart linter in #11238 .
Let me assign assign myself.
/assign

@sbueringer
Copy link
Member

All yours :) Thx for working on this

@sbueringer sbueringer mentioned this issue Mar 5, 2025
Merged
@tsuzu tsuzu mentioned this issue Mar 6, 2025
Merged
@sbueringer sbueringer mentioned this issue Mar 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsuzu tsuzu

@sivchari sivchari

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@sbueringer @fabriziopandini @tsuzu @JoelSpeed @k8s-ci-robot @sivchari