Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support taint in node creation #240

Closed
jichenjc opened this issue Jun 14, 2019 · 1 comment · Fixed by #246
Closed

support taint in node creation #240

jichenjc opened this issue Jun 14, 2019 · 1 comment · Fixed by #246
Assignees
@jichenjc
Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider kind/feature Categorizes issue or PR as related to a new feature.

Comments

@jichenjc
Copy link
Contributor

/kind feature
/sig ibmcloud

Describe the solution you'd like
[A clear and concise description of what you want to happen.]

kubernetes-sigs/cluster-api#493

Taints are included in machine.spec, we can honor the Taint configuration as
https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/pull/116/files

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/provider/ibmcloud Issues or PRs related to ibmcloud provider labels Jun 14, 2019
@jichenjc
Copy link
Contributor Author

/assign

@jichenjc jichenjc mentioned this issue Jun 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jichenjc jichenjc

Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add taint support to master and worker node jichenjc/cluster-api-provider-ibmcloud
2 participants
@jichenjc @k8s-ci-robot