Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide human understandable target group names #870

Closed
sdavids13 opened this issue Feb 23, 2019 · 16 comments
Closed

Provide human understandable target group names #870

sdavids13 opened this issue Feb 23, 2019 · 16 comments

Comments

@sdavids13
Copy link

I would like to use CloudWatch to gather metrics dealing with various Target Groups behind an ELB but is very difficult to at-a-glance understand which Target Group is having issues due to the UUIDs/hashes being generated as the names currently. It would be nice to have some sort of configurable option to specify the name or at least a prefix to denote what Kubernetes service you are using (default value to a combination of servicer name + namespace would be nice).

@shankarramshivram
Copy link

one option is by using the --alb-name-prefix, we get the option to prefix the alb and the target group with a useful name. the alb and target group then gets created with <prefix-name>-......

@M00nF1sh
Copy link
Collaborator

M00nF1sh commented Mar 8, 2019

I have been planing to change the targetGroup name to k8s-{namespace:8}-{name:8}-{uuid:10}.
uuid is hash consisted of clusterName, targetType, protocol, etc. Which should be good enough for general use cases.
(actually in my NLB PR kubernetes/kubernetes#74910, i did that name change for NLB targetGroups).

For Ingress controller, the --alb-name-prefix have forbids me to do so, needs to figure out the real use case of such flag.

@sdavids13
Copy link
Author

sdavids13 commented Mar 9, 2019 via email

@rverma-nikiai
Copy link

Do we have a solution for this?

@M00nF1sh
Copy link
Collaborator

@rverma-nikiai
What's your ideal name for targetGroups?
Will k8s-{namespace:8}-{name:8}-{uuid:10} be good enough for you?

@rverma-nikiai
Copy link

rverma-nikiai commented Apr 14, 2019

@M00nF1sh I would prefer k8-{ing/svc name}-{namespace}-{UUID:10}. Your suggestion is very good too.

@rverma-nikiai
Copy link

Also it would be nice that once we deploy the fix it should take care of deleting the existing random names and creating new target groups

@rverma-nikiai
Copy link

@M00nF1sh Looking forward to a release with this feature. Thanks

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 24, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 23, 2019
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kerma
Copy link

kerma commented Feb 14, 2020

/reopen
/remove-lifecycle rotten

Please?

@k8s-ci-robot
Copy link
Contributor

@kerma: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to this:

/reopen
/remove-lifecycle rotten

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Feb 14, 2020
@threesquared
Copy link

Custom ALB names are now supported via annotations. Can this be provided for target group names as well? Or at least use the same custom ALB name when creating the target group?

@guillaumecle
Copy link

Should we create a dedicated issue for the ability to name the target group as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants