This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[nginx-ingress-controller] Basic auth header is not stripped #1383
Comments
@atombender use a custom template and add |
@aledbf Thanks, I discovered the template just now. That's just a temporary workaround, of course. |
Yes, tomorrow I will open a PR to remove the |
@aledbf: This PR fixed the issue for me. |
@atombender awesome. Thanks! |
Sorry that I have to ask under a closed issue, but how is it possible to pass the authorization header to an upstream now? I see the condition |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
If you use basic auth in an ingress, then the
Authorization
header is passed along to the proxied upstream, which can result in incorrect behaviour if the upstream doesn't expect one.For example, Drone will ignore its session cookie if the auth header is specified.
The correct behaviour is to strip the header and not pass it to the upstream.
Until this is fixed, I've been trying to find a workaround by injecting a custom Nginx directive, but I can't a way. Is there one?
The text was updated successfully, but these errors were encountered: