-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support make container on arm64 architecture #389
Conversation
Signed-off-by: wangzihao <[email protected]>
Welcome @Wangzihao18! |
Hi @Wangzihao18. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Wangzihao18 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @saad-ali |
Sorry, I am not very familiar with raising PRs, it seems I modify the contents in the dictionary
What should I do to make it pass? thanks! |
@Wangzihao18 Yeah, the release-tool directory comes from csi-release-tools repo. I believe you need to modify that repo and then those changes can be updated here. |
/ok-to-test |
Signed-off-by: wangzihao <[email protected]>
/retest |
@Wangzihao18: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Thanks! Happy new year @Pensu . I have raised a PR in the csi-release-tools repo.kubernetes-csi/csi-release-tools#59. Is that right? |
Hey, thanks @Wangzihao18. A very happy new year to you too! Yeah, that looks good. Thanks. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…update-master Update K8s dependency go modules for K8s v1.26.0-rc.0
Signed-off-by: wangzihao [email protected]
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add support for multi-arch
Which issue(s) this PR fixes:
Fixes #381
Special notes for your reviewer:
use Kunpeng920(arm) and Xeon 6148(x86) to test building.
Does this PR introduce a user-facing change?: