keepalive API #239
Merged
keepalive API #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pohly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
k8s-ci-robot
added
size/XXL
Sometimes it may be useful to connect to a CSI driver via TCP, for example when controller and node service aren't running on the same host. The mock driver can be used to test this mode of operation now. It accepts the same "tcp://<host>:<port" and "unix://<path>" syntax as other CSI drivers while still supporting just plain "<path>" for backwards compatibility.
The gRPC defaults for a client do not work for a gRPC server that also uses the defaults (grpc/grpc-go#3171) which caused connection drops when a CSI driver is slow to respond and the client starts sending keepalive pings too quickly (kubernetes-csi#238). The sanity package no longer uses gRPC keepalive. Instead, custom test suites can enable that via some new configuration options if needed and when it is certain that the CSI driver under test can handle it.
k8s-ci-robot
added
size/L
|
@wnxn: can you perhaps review this PR? |
|
@pohly When I reproduce the keepalive problem, the subsequent testcases failed for the TransientFailure. grpc/grpc-go#2669 |
It makes sense to do that, but it should better be a separate PR. |
|
LGTM |
wnxn
approved these changes
Nov 14, 2019
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind api-change
What this PR does / why we need it:
Enabling gRPC keepalive breaks connections if the CSI driver isn't prepared for it. When testing this is was useful to also support TCP in the mock driver.
Which issue(s) this PR fixes:
Fixes #238
Special notes for your reviewer:
Depends on PR #233
Does this PR introduce a user-facing change?: