Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run travis builds for ppc64le #62

Closed
wants to merge 1 commit into from

Conversation

Pensu
Copy link
Contributor

@Pensu Pensu commented Jan 4, 2020

This is in ref to #48 and an extension to the PR: #47. This PR allows the travis build to run for ppc64le env as well. Here are the changes done:

  1. Add image name based on arch. For amd64 image names remains same, for ppc64le, add -ppc64le to the image name.
  2. Add arch variable in travis.yaml to run the build on both amd64 and ppc64le archs and make go version same for all builds.
  3. Disable shellcheck for ppc64le, as shellcheck is not available for the arch yet. (A issue has been opened: shellcheck for ppc64le koalaman/shellcheck#1767)
  4. Download the correct dep binary for the given arch.

@k8s-ci-robot
Copy link
Contributor

@Pensu: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 4, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @Pensu. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 4, 2020
@k8s-ci-robot k8s-ci-robot requested review from msau42 and pohly January 4, 2020 11:40
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Pensu
To complete the pull request process, please assign saad-ali
You can assign the PR to them by writing /assign @saad-ali in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Pensu
Copy link
Contributor Author

Pensu commented Jan 7, 2020

Hi @msau42 @pohly @saad-ali, can you please help in reviewing this? Thanks.

@msau42
Copy link
Collaborator

msau42 commented Jan 7, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 7, 2020
@msau42
Copy link
Collaborator

msau42 commented Jan 7, 2020

We are in the process of moving away from travis to prow for image releasing. Do we know if prow supports cross builds?

@Pensu
Copy link
Contributor Author

Pensu commented Jan 20, 2020

Closing in favor of #68

@Pensu Pensu closed this Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants