Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #127: add option to limit grpc logging length #128

Conversation

leiyiz
Copy link
Contributor

@leiyiz leiyiz commented Jan 18, 2023

Cherry pick of #127 on release-0.12.

#127: add option to limit grpc logging length

For details on the cherry pick process, see the cherry pick requests page.


@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 18, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: leiyiz
Once this PR has been reviewed and has the lgtm label, please assign jsafrane for approval by writing /assign @jsafrane in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 18, 2023
@leiyiz
Copy link
Contributor Author

leiyiz commented Jan 18, 2023

/assign @jsafrane

@jsafrane
Copy link
Contributor

Does it make sense to backport this change? It does not look like a bugfix to me.

@leiyiz
Copy link
Contributor Author

leiyiz commented Jan 18, 2023

I guess what I'm trying to do is to release a new version of csi-lib-utils to include this and it seemed fit to do a 0.12.1 version because it is not introducing any breaking changes.

@msau42
Copy link
Collaborator

msau42 commented Jan 18, 2023

I think it's ok to release a 0.13.0 and use that in csi-attacher

@leiyiz leiyiz closed this Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants