Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Changelog for 1.1.0 #45

Closed
wants to merge 1 commit into from
Closed

Add Changelog for 1.1.0 #45

wants to merge 1 commit into from

Conversation

jsafrane
Copy link
Contributor

@jsafrane jsafrane commented Apr 9, 2019 •
edited
Loading

@msau42, PTAL

Note: not bumped to 2.0, IMO "action needed" is enough

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 9, 2019
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 9, 2019
@jsafrane
Copy link
Contributor Author

jsafrane commented Apr 9, 2019

/hold
waiting for cluster registrar deprecation in #44 to get resolved

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 9, 2019
msau42
msau42 reviewed Apr 9, 2019
View reviewed changes
Copy link
Collaborator

@msau42 msau42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to release a new version? Or should we just deprecate and stop releasing the entire sidecar?

CHANGELOG-1.1.md
* release tools: fix "canary" + enhance testing ([#23](https://github.com/kubernetes-csi/cluster-driver-registrar/pull/23))
* Update usage and deployment documentation ([#20](https://github.com/kubernetes-csi/cluster-driver-registrar/pull/20))
* Add more details about cluster-driver-registrar ([#10](https://github.com/kubernetes-csi/cluster-driver-registrar/pull/10))
* Auto-detect AttachRequired ([#4](https://github.com/kubernetes-csi/cluster-driver-registrar/pull/4))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change removed a command line flag, which is breaking. It's also alpha so I think that's fine, but we should call it out

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed + added note about -pod-info-mount-version -> -pod-info-mount.

We should have a bot that compares --help output :-)

lpabon
lpabon reviewed Apr 10, 2019
View reviewed changes
CHANGELOG-1.1.md

## Other notable changes

* Use distroless as base image ([#39](https://github.com/kubernetes-csi/cluster-driver-registrar/pull/39))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job on all the comments. Did you do this by hand?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get PR numbers from all merge commits since the last release + get titles of these PRs. + some manual editing.

Stay tuned for kubernetes-csi/docs#142!

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 10, 2019
@childsb
Copy link

childsb commented Apr 17, 2019

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2019
vladimirvivien
vladimirvivien reviewed Apr 17, 2019
View reviewed changes
Copy link
Member

@vladimirvivien vladimirvivien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vladimirvivien
Copy link
Member

/LGTM

@vladimirvivien
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: childsb, jsafrane, vladimirvivien

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jsafrane,vladimirvivien]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 16, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 15, 2019
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladimirvivien vladimirvivien vladimirvivien left review comments

@lpabon lpabon lpabon left review comments

@msau42 msau42 msau42 left review comments

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@vladimirvivien vladimirvivien

@childsb childsb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jsafrane @childsb @vladimirvivien @k8s-ci-robot @fejta-bot @lpabon @msau42