Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure we don't lose information about on what cloud provider we deploy cluster when using external CCM #168

Closed
1 task
xmudrii opened this issue Jan 11, 2019 · 2 comments · Fixed by #230
Closed
1 task

Ensure we don't lose information about on what cloud provider we deploy cluster when using external CCM #168

xmudrii opened this issue Jan 11, 2019 · 2 comments · Fixed by #230
Assignees
@xmudrii
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/normal Not that urgent, but is important
Milestone
v0.3.0

Comments

@xmudrii
Copy link
Member

xmudrii commented Jan 11, 2019 •
edited
Loading

Follow-up of #161

To use external CCM (Cloud Controller Manager), provider.Name field needs to be set to external instead of cloud provider's name. With this implementation, we're losing information on what cloud provider we deploy the cluster, and therefore lose some features such as Terraform automation for worker nodes.

Acceptance criteria:

  • Ensure we don't lose information about on what cloud provider we deploy cluster when using external CCM
@xmudrii xmudrii changed the title Ensure we don Ensure we don't lose information about on what cloud provider we deploy on when using external CCM Jan 11, 2019
@xmudrii xmudrii changed the title Ensure we don't lose information about on what cloud provider we deploy on when using external CCM Ensure we don't lose information about on what cloud provider we deploy cluster when using external CCM Jan 11, 2019
@xmudrii xmudrii added kind/bug Categorizes issue or PR as related to a bug. priority/normal Not that urgent, but is important labels Jan 11, 2019
@xmudrii xmudrii added this to the v0.3.0 milestone Mar 1, 2019
@kron4eg
Copy link
Member

kron4eg commented Mar 4, 2019

dependent and blocked by #227 as they share common idea/logic

@xmudrii
Copy link
Member Author

xmudrii commented Mar 5, 2019

/assign
/lifecycle active

@kubermatic-bot kubermatic-bot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Mar 5, 2019
@xmudrii xmudrii mentioned this issue Mar 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xmudrii xmudrii

Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/normal Not that urgent, but is important
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging a pull request may close this issue.

Implement proper support for external CCM and cloud-config kubermatic/kubeone
3 participants
@kron4eg @xmudrii @kubermatic-bot