-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to volcano 0.4.0 #887
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -32,24 +32,16 @@ $ git clone [email protected]:GoogleCloudPlatform/spark-on-k8s-operator.git | |
| $ cd spark-on-k8s-operator | ||
| ``` | ||
|
|
||
| Before building the operator the first time, run the following commands to get the required Kubernetes code generators: | ||
|
|
||
| ```bash | ||
| $ go get -u k8s.io/code-generator/cmd/client-gen | ||
| $ go get -u k8s.io/code-generator/cmd/deepcopy-gen | ||
| $ go get -u k8s.io/code-generator/cmd/defaulter-gen | ||
| $ go get -u sigs.k8s.io/controller-tools/cmd/controller-gen | ||
| ``` | ||
|
|
||
| To update the auto-generated code, run the following command. (This step is only required if the CRD types have been changed): | ||
|
|
||
| ```bash | ||
| $ go generate | ||
| $ hack/update-gencode.sh | ||
| ``` | ||
|
|
||
| To update the auto-generated CRD definitions, run the following command: | ||
|
|
||
| ```bash | ||
| $ GO111MODULE=off go get -u sigs.k8s.io/controller-tools/cmd/controller-gen | ||
| $ controller-gen crd:trivialVersions=true,maxDescLen=0 paths="./pkg/apis/sparkoperator.k8s.io/v1beta2" output:crd:artifacts:config=./manifest/crds/ | ||
| ``` | ||
|
|
||
|
|
@@ -79,4 +71,4 @@ When you update the API, or specifically the `SparkApplication` and `ScheduledSp | |
| make build-api-docs | ||
| ``` | ||
|
|
||
| Running the above command will update the file `docs/api-docs.md`. | ||
| Running the above command will update the file `docs/api-docs.md`. | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which k8s version does
v0.16.6correspond to?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.16.6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the k8s related dependencies are 1.16.6 now