Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to volcano 0.4.0 #887

Merged
merged 6 commits into from
Apr 24, 2020
Merged

Bump to volcano 0.4.0 #887

merged 6 commits into from
Apr 24, 2020

Conversation

hzxuzhonghu
Copy link
Contributor

Depend on #886

@liyinan926
Copy link
Collaborator

Please rebase and resolve the conflict.

@@ -378,7 +378,7 @@ func (wh *WebHook) selfRegistration(webhookConfigName string) error {
},
}

mutatingWebhook := v1beta1.Webhook{
mutatingWebhook := v1beta1.MutatingWebhook{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it has been renamed in a newer version of the k8s API?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes long ago

)

replace (
k8s.io/api => k8s.io/api v0.16.6
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which k8s version does v0.16.6 correspond to?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.16.6

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the k8s related dependencies are 1.16.6 now

Copy link
Collaborator

@liyinan926 liyinan926 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@liyinan926 liyinan926 merged commit 7cd886c into kubeflow:master Apr 24, 2020
@hzxuzhonghu hzxuzhonghu deleted the volcano branch April 24, 2020 05:57
jbhalodia-slack pushed a commit to jbhalodia-slack/spark-operator that referenced this pull request Oct 4, 2024
* Upgrade volcano to v0.4.0

* fix gen code

* fiox build

* fix test

* update developer guide

* fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants