Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to go module #886

Merged
merged 5 commits into from
Apr 23, 2020
Merged

Migrate to go module #886

merged 5 commits into from
Apr 23, 2020

Conversation

hzxuzhonghu
Copy link
Contributor

No description provided.

@hzxuzhonghu
Copy link
Contributor Author

/assign @liyinan926

Copy link
Collaborator

@liyinan926 liyinan926 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to update docs/developer-guide.md, which has some mentioning of dep also.

@hzxuzhonghu
Copy link
Contributor Author

ok. thanks for the review

Copy link
Collaborator

@liyinan926 liyinan926 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@liyinan926 liyinan926 merged commit 3e528cb into kubeflow:master Apr 23, 2020
@hzxuzhonghu hzxuzhonghu deleted the go-mod branch April 23, 2020 06:07
jbhalodia-slack pushed a commit to jbhalodia-slack/spark-operator that referenced this pull request Oct 4, 2024
* Migrate to go mod

* rm gopkg

* update travis ci

* remove dep totally

* remove dep from developer guide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants