-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk): Add Input Parameter support for configmap, secrets, node selectors, tolerations, pull secrets #11621
base: master
Are you sure you want to change the base?
Conversation
c9c3858
to
61860db
Compare
cc @chensun please review the proto changes here when you get the chance so we are aligned here, as some fields are also being deprecated |
Please also note that this is a more generic implementation of how we were handling inputs already for pvc mounts in the k8s platform spec here, but extended to various other fields One thing also worth noting is that we probably don't need the entire |
|
The tests failures are a redherring, it's because of the compiled proto packages that are not utilizing the new code |
61860db
to
e45ba7a
Compare
0bd1120
to
e93d731
Compare
9f1bdb5
to
9e3efbd
Compare
9e3efbd
to
745691f
Compare
6115f6d
to
ae0f759
Compare
ae0f759
to
d61886a
Compare
06de2bc
to
5106646
Compare
cc @chensun wdyt? any objections to merging this? Once done I'll follow up with backend PR. |
5106646
to
07d2f11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
# Ensure Python can find the protobuf-generated modules | ||
# This is needed in order to resolve common proto python module | ||
# that is generated via generate_proto.py | ||
package_dir = os.path.dirname(os.path.abspath(__file__)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well we need this line to be recognizable in kubernetes_executor_config_pb2.py
(the python proto output):
import pipeline_spec_pb2 as pipeline__spec__pb2
here python will not be able to find this module because we're outputing it in the same location
another maybe a more preferable approach can be to just create the module directory with an __init__.py
and have the output go there, this should get it to work and we can drop these lines
I don't have a strong preference
This change adds the necessary proto changes to accomodate parameterized input for various k8s platform fields: secrets, configmaps, node selectors, tolerations, and image pull secrets. Signed-off-by: Humair Khan <[email protected]>
07d2f11
to
081fc7a
Compare
New changes are detected. LGTM label has been removed. |
081fc7a
to
6e83f3a
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of your changes:
Related:
set_env_variable
compatible with the channels [KFP V2] #10111These will be marked resolved once the backend & sdk changes are merged after this.
This change provides proto api support for the following kubernetes platform
fields:
Checklist: