fix cloud usage defaulting #1388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Fixes default value for ETL_CLOUD_USAGE_ENABLED environment variable. Previous defaults failed because they were depended on values.yaml values being of type boolean, ie having a value, which means that the default was never used. I have removed this type of defaulting and replaced it with a base case else clause.
Does this PR rely on any other PRs?
How does this PR impact users? (This is the kind of thing that goes in release notes!)
Users will see ETL_CLOUD_USAGE_ENABLED=true in their env variables. No product impact.
Links to Issues or ZD tickets this PR addresses or fixes
How was this PR tested?
This PR was tested by using the helm chart with none of the relevant values set, and ensuring that a default value was set.
Have you made an update to documentation?