Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cluster controller service key secret optional #1379

Merged
merged 2 commits into from
Apr 19, 2022
Merged

Make cluster controller service key secret optional #1379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b60bf60
cluster controller service key secret optional
michaelmdresser Apr 18, 2022
2b68dfa
cluster controller to v0.0.6 for optional secret
michaelmdresser Apr 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions cost-analyzer/templates/kubecost-cluster-controller-template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,11 @@ spec:
- name: cluster-controller-keys
secret:
secretName: {{ .Values.clusterController.secretName | default "cluster-controller-service-key" }}
# The secret is optional because not all of cluster controller's
# functionality requires this secret. Cluster controller will
# partially or fully initialize based on the presence of these keys
# and their validity.
optional: true
---
apiVersion: v1
kind: Service
Expand Down
2 changes: 1 addition & 1 deletion cost-analyzer/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -604,7 +604,7 @@ kubecostDeployment:
# Kubecost Cluster Controller for Right Sizing and Cluster Turndown
clusterController:
enabled: false
image: gcr.io/kubecost1/cluster-controller:v0.0.5
image: gcr.io/kubecost1/cluster-controller:v0.0.6
imagePullPolicy: Always
# fqdn: kubecost-cluster-controller.kubecost.svc.cluster.local:9731

Expand Down