Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Google Analytics Tag Name #1374

Merged
merged 2 commits into from
Apr 19, 2022
Merged

Fixed Google Analytics Tag Name #1374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c095a53
Fixed tag names.
teevans Apr 15, 2022
364c15b
Updated google analytics tag to be marked as enterprise.
teevans Apr 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cost-analyzer/templates/cost-analyzer-deployment-template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,9 +673,9 @@ spec:
- name: PROM_CLUSTER_ID_LABEL
value: {{ .Values.kubecostModel.promClusterIDLabel }}
{{- end }}
{{- if .Values.kubecostFrontend.customerGoogleTag }}
- name: CUSTOMER_GOOGLE_TAG
value: {{ .Values.kubecostFrontend.customerGoogleTag }}
{{- if .Values.reporting.googleAnalyticsTag }}
- name: GOOGLE_ANALYTICS_TAG
value: {{ .Values.reporting.googleAnalyticsTag }}
{{- end }}
- name: RELEASE_NAME
value: {{ .Release.Name }}
Expand Down
6 changes: 4 additions & 2 deletions cost-analyzer/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,8 +198,6 @@ kubecostFrontend:
#limits:
# cpu: "100m"
# memory: "256Mi"
# customerGoogleTag allows you to embed your Google Global Site Tag to track usage of Kubecost.
# customerGoogleTag: G-XXXXXXXXX
# api:
# fqdn: kubecost-api.kubecost.svc.cluster.local:9001
# model:
Expand Down Expand Up @@ -614,9 +612,13 @@ reporting:
logCollection: true
# Basic frontend analytics
productAnalytics: true

# Report Javascript errors
errorReporting: true
valuesReporting: true
# googleAnalyticsTag allows you to embed your Google Global Site Tag to track usage of Kubecost.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be a paid feature since it's mostly an enterprise use case. Want to mark as such? Happy to discuss.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to do that - Do we need to do anything other than mark it here and implement the gate on the front end?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can discuss, but my vote is just mark for now!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doneski.

# googleAnalyticsTag is only included in our Enterprise offering.
# googleAnalyticsTag: G-XXXXXXXXX

serviceMonitor:
enabled: false
Expand Down