Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin local chart dependencies in Chart.yaml files #1192

Merged
merged 4 commits into from
Apr 20, 2022
Merged

Pin local chart dependencies in Chart.yaml files #1192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6ef8889
Pin local chart dependencies in Chart.yaml files
keithhand Jan 5, 2022
7301981
Merge branch 'kubecost:develop' into keithhand-pin-chart-dependencies
keithhand Jan 20, 2022
d80791a
Add condition flags for dependencies
keithhand Jan 21, 2022
2a79e87
Add condition flag for kube-state-metrics chart
keithhand Jan 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions cost-analyzer/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,13 @@ annotations:
"artifacthub.io/links": |
- name: Homepage
url: https://www.kubecost.com
dependencies:
- condition: global.grafana.enabled
name: grafana
repository: file://./charts/grafana
Comment on lines +13 to +15
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @nealormsbee for your (eventual) Grafana deprecation/removal

- condition: global.prometheus.enabled
name: prometheus
repository: file://./charts/prometheus
- condition: global.thanos.enabled
name: thanos
repository: file://./charts/thanos
4 changes: 4 additions & 0 deletions cost-analyzer/charts/prometheus/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,7 @@ sources:
- https://github.com/kubernetes/kube-state-metrics
tillerVersion: '>=2.8.0'
version: 11.0.2
dependencies:
- condition: kube-state-metrics.disabled
name: kube-state-metrics
repository: file://./charts/kube-state-metrics
Comment on lines +21 to +24
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AjayTripathy After our metrics emission changes, do we still need to have KSM in the Helm chart?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not but that's a pretty big change outside the scope of this PR.