Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for crio #93

Closed
wants to merge 2 commits into from
Closed

Add support for crio #93

wants to merge 2 commits into from

Conversation

vikasvr
Copy link
Contributor

@vikasvr vikasvr commented Jun 25, 2022

Referencing issue: kubearmor/KubeArmor#221

Added support for cri-o.

Before: Unable to run karmor install on openshift due to missing runtime support for cri-o
Now: I was able to run karmor install successfully without any errors.

Signed-off-by: Vikas Verma [email protected]

@vikasvr vikasvr changed the title Add support for crio [Vikas Verma] Add support for crio Jun 25, 2022
@daemon1024
Copy link
Member

Nice!

Now: I was able to run karmor install successfully without any errors.

karmor install would work successfully with this but the installed daemonset wouldn't work as intended, since it would have mount paths based on generic env i.e. containerd sockets instead of crio ones.

We recently added support for CRI-O in KubeArmor as part of kubearmor/KubeArmor#666.

Since we can already detect crio here, let's add support for new env.
This would require modifications in our deployments/get pkg which can based off of https://github.com/kubearmor/KubeArmor/blob/main/KubeArmor/build/kubearmor-test-crio.yaml#L80=L85

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants