kube-core type movement #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
think this completes the type migration to kube-core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #517
Moves more files to kube-core so that most core types and traits live therein, and kube gets the harder business logic around tokio and clients.
Could potentially move
Apiin to an async_trait into kube-core at some point, but no need for it atm.kube::api::{metadata,object,dynamic, gvk}(but kept re-exports to avoid breaking)ErrorResponse(was used byWatchEvent(again, re-exported)GroupfromdiscoverytoApiGroupto matchApiResource(small follow-up to Separate GVK from ApiResource #495)There is something to be said by the re-export structure, and the lack of re-exports inside kube-core, but it works as a first sketch I think.