Move authentication logic out of config #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazk
force-pushed
the
auth-logic-to-service
branch
from
5a527fe to
66726be
Compare
kazk
commented
Feb 9, 2021
| "https://www.googleapis.com/auth/cloud-platform,https://www.googleapis.com/auth/userinfo.email"; | ||
| // Initialize ServiceAccountAccess so we can request later when needed. | ||
| let info = gcloud_account_info()?; | ||
| let access = ServiceAccountAccess::new(info).map_err(OAuthError::InvalidKeyFormat)?; |
There was a problem hiding this comment.
ServiceAccountAccess has internal cache and returns Request when it's necessary to refresh the token. See token below.
kazk
force-pushed
the
auth-logic-to-service
branch
from
66726be to
d1dbe24
Compare
clux
approved these changes
Feb 9, 2021
|
|
||
| let mut value = HeaderValue::from_str(&format!("Bearer {}", &locked_data.0)) | ||
| .map_err(ConfigError::InvalidBearerToken)?; | ||
| value.set_sensitive(true); |
kazk
force-pushed
the
auth-logic-to-service
branch
from
91701dd to
e5da843
Compare
kazk
force-pushed
the
auth-logic-to-service
branch
from
6ee2b6e to
080fe9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Config should focus on finding and loading the configuration. Setting up auth and refreshing token is now handled by service.
Config is now free of
native-tls/rustls-tlsexcept for the macOS hack.