Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom runtime with MLServer #222

Closed
oha95 opened this issue Aug 31, 2022 · 3 comments
Closed

Custom runtime with MLServer #222

oha95 opened this issue Aug 31, 2022 · 3 comments
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@oha95
Copy link

oha95 commented Aug 31, 2022

I tried to follow the documentation to create a custom runtime server

but I think there is an error in the Dockerfile.
Is this the last instruction :

RUN mlserver start $MLSERVER_MODELS_DIR

in that case the image never finish the build. It is not rather:

CMD mlserver start $MLSERVER_MODELS_DIR
@oha95 oha95 added the bug Something isn't working label Aug 31, 2022
@njhill
Copy link
Member

njhill commented Aug 31, 2022

Thanks @oha95 it does look like this is a doc bug. Would you like to open a PR to fix it?

@njhill njhill added the documentation Improvements or additions to documentation label Aug 31, 2022
@oha95
Copy link
Author

oha95 commented Sep 1, 2022

Hello @njhill, yes of course, but first I want to test it on my cluster to make sure it works. I'll probably do it this weekend

@rafvasq
Copy link
Member

rafvasq commented Feb 24, 2023

This doc bug was addressed by #277

@rafvasq rafvasq closed this as completed Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants