Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot read property 'cssClass' of undefined #136

Closed
justinbwarner opened this issue Feb 29, 2016 · 5 comments
Closed

Cannot read property 'cssClass' of undefined #136

justinbwarner opened this issue Feb 29, 2016 · 5 comments

Comments

@justinbwarner
Copy link

Getting an error with version 0.8.6 that didn't happen in 0.8.5. Created a plunker that reproduces the issue:

https://embed.plnkr.co/snAKVOxXDSEobEdr81WK/

Cannot read property 'cssClass' of undefined
at FlotTooltip.getDomElement (jquery.flot.tooltip.js:329)
at Plot.FlotTooltip.init.plot.removeTooltip (jquery.flot.tooltip.js:320)
at jquery.flot.tooltip.js:116
at executeHooks (jquery.flot.js:717)
at Plot.shutdown (jquery.flot.js:1363)
at setupCanvases (jquery.flot.js:1327)
at new Plot (jquery.flot.js:707)

@krzysu
Copy link
Owner

krzysu commented Mar 1, 2016

I see there was an API change, and backwards compatibility is not written perfectly ;)

just try using new configuration object:

instead of

tooltip: true,
tooltipOpts: {
    content: "%s %x, %y"
}

use

tooltip: {
    show: true,
    content: "%s %x, %y"
}

let me know if it helps!

@loren138
Copy link

loren138 commented Mar 4, 2016

This error seems to occur if you have flot.tooltip.js installed, but do not have tooltips turned on for a particular graph. (ie show: false or no tooltip config at all)

Also, this is a 2.8.X release it should have no new features or API changes only bug fixes. A backwards breaking change should only occur in an X.0.0 release so those of us who automatically pull in bugfix release don't end up with broken projects.

@krzysu
Copy link
Owner

krzysu commented Mar 8, 2016

I agree with breaking changes and versioning, unfortunately I'm not an active maintainer of this repo, talk with @Roundaround

@po5i
Copy link

po5i commented Mar 14, 2016

Seems that can be fixed with #138

@krzysu
Copy link
Owner

krzysu commented Mar 15, 2016

#138 merged and released as 0.8.7, let me know if everything is fine

@krzysu krzysu closed this as completed Mar 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants