Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for critical css without css modules #51

Open
pastelsky opened this issue Jul 23, 2016 · 2 comments
Open

Support for critical css without css modules #51

pastelsky opened this issue Jul 23, 2016 · 2 comments

Comments

@pastelsky
Copy link

pastelsky commented Jul 23, 2016

Not every project uses css modules and there are signs that the react team are against using css modules. Does this library support critical css when components import css like

import component/mystyle.css

Theoretically speaking, it should be possible to find out which components are rendered above the fold, and then resolve css imports from those components into critical path css.

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/36281242-support-for-critical-css-without-css-modules?utm_campaign=plugin&utm_content=tracker%2F26439769&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F26439769&utm_medium=issues&utm_source=github).
@Everettss
Copy link
Contributor

@pastelsky You strongly misunderstood goal of create-react-app. Facebook react team are NOT against CSS-modules, they are simply trying to create generic and workflow agnostic (I'm talking about webpack) application in create-react-app project. So since they are going to remove webpack at all in the future they can not support CSS-modules loader.

Back to your question: if you are happy with weback you should not to worry about CSS-modules or isomorphic-style-loader and your improve suggestion will not change create-react-app team point of view - neither ours.

@jooj123
Copy link

jooj123 commented Feb 15, 2018

css modules is now supported in create-react-app - that article that was linked is outdated now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants