Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What changed in the WASM memory usage measurements at Chrome 104? #1218

Closed
gbj opened this issue Mar 20, 2023 · 2 comments
Closed

What changed in the WASM memory usage measurements at Chrome 104? #1218

gbj opened this issue Mar 20, 2023 · 2 comments

Comments

@gbj
Copy link
Contributor

gbj commented Mar 20, 2023

If you compare benchmark runs for Chrome prior to 104 and Chrome 104 and later, you see a sudden increase in memory usage across every benchmark for every WASM framework, even without a version bump in the framework. In most cases, this leads to a reversal of the results when comparing similar JS and WASM frameworks.

Chrome 103 OSX: Sycamore uses less memory than Solid, Yew uses less memory than React
Screenshot 2023-03-20 at 11 33 01 AM

Chrome 104 OSX: Sycamore uses more memory than Solid, Yew uses more memory than React
Screenshot 2023-03-20 at 11 33 26 AM

Granted Sycamore had a version bump in there, but Yew and React are identical versions.

I'm curious if you know what happened in the way memory use is measured or maybe in the way Chrome reports it, or possibly even in the way Chrome allocates it.

@krausest
Copy link
Owner

Between Chrome 103 and 104 we added a memory metric for 10k rows. And there was a discussion that lead to a different method to compute the memory usage (see #1050 (comment) ). We're now using performance.measureUserAgentSpecificMemory() and thus the results changed.

@gbj
Copy link
Contributor Author

gbj commented Mar 23, 2023

Thanks. That at least answers the question of why it changed. It's not clear to me that it's a particularly useful measurement in its current form, given the counter-intuitive and systematic WASM vs JS discrepancy, but I'll yield to your judgment and the judgment of the folks involved in the discussion who know much more about Chrome performance stats than I do!

@gbj gbj closed this as completed Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants