Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gatekeeper function should use the Go SDK #762

Closed
frankfarzan opened this issue Jun 24, 2020 · 3 comments
Closed

Gatekeeper function should use the Go SDK #762

frankfarzan opened this issue Jun 24, 2020 · 3 comments
Labels
area/fn-catalog Functions Catalog cleanup p2 triaged Issue has been triaged by adding an `area/` label

Comments

@frankfarzan
Copy link
Contributor

Currently, Gatekeeper function:

https://github.com/GoogleContainerTools/kpt-functions-sdk/blob/master/go/pkg/functions/gatekeeper/validate.go

Doesn't use the Kpt Go SDK:

https://googlecontainertools.github.io/kpt/guides/producer/functions/golang/

It uses an early minimal Go library which was built to unblock Gatekeeper before an official SDK was released. We should refactor Gatekeeper function and delete that purpose-built library.

@mortent mortent added area/fn-catalog Functions Catalog cleanup p2 triaged Issue has been triaged by adding an `area/` label labels Jun 26, 2020
@prachirp
Copy link
Contributor

Once it uses the Go SDK we can move it into kpt-functions-catalog repo

@mengqiy
Copy link
Contributor

mengqiy commented Jan 29, 2021

As other golang-based kpt functions, gatekeeper should use sigs.k8s.io/kustomize/kyaml.

@mengqiy
Copy link
Contributor

mengqiy commented Apr 15, 2021

@mengqiy mengqiy closed this as completed Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/fn-catalog Functions Catalog cleanup p2 triaged Issue has been triaged by adding an `area/` label
Projects
None yet
Development

No branches or pull requests

4 participants