Kpt should use internal.config.kubernetes.io/* annotations

[mengqiy]

Kpt should use the annotations as specified in https://github.com/kubernetes-sigs/kustomize/blob/master/cmd/config/docs/api-conventions/functions-spec.md#internal-annotations.

For example, kpt currently use config.kubernetes.io/path but it should use internal.config.kubernetes.io/path.

[natasha41575]

Issue on kustomize side: kubernetes-sigs/kustomize#4024

LMK if you plan to take care of it on both sides or I should still work on it. I'm guessing the fix will be in kyaml for both kpt and kustomize.

[mengqiy]

I will take a closer look

I'm guessing the fix will be in kyaml for both kpt and kustomize.

That's very likely to be the case.

[droot]

The fix needs to be done in kyaml (common orchestrator layer) as part of kubernetes-sigs/kustomize#4024. @natasha41575 No plans to address this in the short term on kpt side yet.

[mengqiy]

This has been confusing for contributors. We should fix it soon.
@natasha41575 Do you have cycle to fix this?
If we want to fix this in kyaml v0.11.*, it should add both config.kubernetes.io/* and internal.config.kubernetes.io/* annotations.
When we are ready to move to kyaml v0.12.0, we can remove the config.kubernetes.io/* annotation support.

[natasha41575]

Do you have cycle to fix this?

Yes, I can take a look this sprint.

If we want to fix this in kyaml v0.11., it should add both config.kubernetes.io/ and internal.config.kubernetes.io/* annotations.

We should do this first, and after some time we can drop support for config.kubernetes.io/* and release 0.12.

[natasha41575]

See kubernetes-sigs/kustomize#4190

[natasha41575]

This is updated in kyaml v0.12.0. I will work on a PR to update kpt.

[droot]

Closing since the PR has been merged.