From 9c0d253cae1d7aca7698156f3cd106945832a4be Mon Sep 17 00:00:00 2001 From: Koushik Dutta Date: Sat, 13 Apr 2024 09:43:34 -0700 Subject: [PATCH] webrtc: fix audio handling on unrecognized codec --- plugins/webrtc/package-lock.json | 4 ++-- plugins/webrtc/package.json | 2 +- plugins/webrtc/src/rtp-forwarders.ts | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/plugins/webrtc/package-lock.json b/plugins/webrtc/package-lock.json index d88ff50943..9a315a0a69 100644 --- a/plugins/webrtc/package-lock.json +++ b/plugins/webrtc/package-lock.json @@ -1,12 +1,12 @@ { "name": "@scrypted/webrtc", - "version": "0.2.22", + "version": "0.2.23", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@scrypted/webrtc", - "version": "0.2.22", + "version": "0.2.23", "dependencies": { "@scrypted/common": "file:../../common", "@scrypted/sdk": "file:../../sdk", diff --git a/plugins/webrtc/package.json b/plugins/webrtc/package.json index 6927fd3c3a..3f2f2d7d54 100644 --- a/plugins/webrtc/package.json +++ b/plugins/webrtc/package.json @@ -1,6 +1,6 @@ { "name": "@scrypted/webrtc", - "version": "0.2.22", + "version": "0.2.23", "scripts": { "scrypted-setup-project": "scrypted-setup-project", "prescrypted-setup-project": "scrypted-package-json", diff --git a/plugins/webrtc/src/rtp-forwarders.ts b/plugins/webrtc/src/rtp-forwarders.ts index 3308dfaf92..2a96865b61 100644 --- a/plugins/webrtc/src/rtp-forwarders.ts +++ b/plugins/webrtc/src/rtp-forwarders.ts @@ -204,7 +204,7 @@ export async function startRtpForwarderProcess(console: Console, ffmpegInput: FF } const audioSections = parsedSdp.msections.filter(msection => msection.type === 'audio'); - let audioSection = audioSections.find(msection => msection.codec === audioCodec || audioCodec === 'copy'); + let audioSection = audioSections.find(msection => (msection.codec && msection.codec === audioCodec) || audioCodec === 'copy'); if (!audioSection) { for (const check of audioSections) { if (await audio?.negotiate?.(check) === true) {