diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 4846293..41eb96a 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -20,16 +20,13 @@ jobs: compiler: llvm - platform: ubuntu-latest compiler: msvc - # llvm doesn't work with libstd++ until P2493R0 is done + # Re-enable after llvm-19 - platform: ubuntu-latest compiler: llvm - platform: macos-13 compiler: msvc - platform: macos-13 compiler: gcc - # Temporary until gcc-14 - - platform: ubuntu-latest - compiler: gcc runs-on: ${{matrix.platform}} steps: @@ -44,6 +41,10 @@ jobs: - name: Set gcc run: | + # Temporary until gcc-14 is officialy released and available on the runner + sudo add-apt-repository "deb http://archive.ubuntu.com/ubuntu/ noble main universe" + sudo apt update + sudo apt install gcc-14 g++-14 echo "CC=gcc-14" >> $GITHUB_ENV echo "CXX=g++-14" >> $GITHUB_ENV shell: bash diff --git a/src/directory.cpp b/src/directory.cpp index e1422fc..bcdbbdc 100644 --- a/src/directory.cpp +++ b/src/directory.cpp @@ -27,7 +27,7 @@ std::expected, WfsError> Directory::GetObject(const std const auto attributes_block = FindObjectAttributes(block_, name); if (!attributes_block.has_value()) return std::unexpected(attributes_block.error()); - return WfsItem::Load(quota_, name, std::move(*attributes_block)); + return WfsItem::Load(quota_, name, *attributes_block); } std::expected, WfsError> Directory::GetDirectory(const std::string& name) const { diff --git a/src/ptree.h b/src/ptree.h index 31a8899..84bad88 100644 --- a/src/ptree.h +++ b/src/ptree.h @@ -146,7 +146,7 @@ class PTreeConstIterator { bool is_end() const { return !leaf_ || leaf_->iterator.is_end(); } private: - const NodeRefCreator* ptree_; + const NodeRefCreator* ptree_{nullptr}; std::vector parents_; std::optional leaf_; };